Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SES #42

Open
tristandostaler opened this issue Jan 24, 2022 · 3 comments
Open

AWS SES #42

tristandostaler opened this issue Jan 24, 2022 · 3 comments
Assignees

Comments

@tristandostaler
Copy link

Hello,

The AWS SES app is missing the possibility to use the "reply to" field of an email

@frikky
Copy link
Member

frikky commented Jan 25, 2022

Hey @shalin24999, could you have a look at this?

@shalin24999
Copy link
Member

Hey @tristandostaler could you please check 257. Is this what you suggested?

@tristandostaler
Copy link
Author

Yes that seems right!

If it's worth anything, the lines 59 to 104 could be simplified without the if, hence reducing the code duplication. The only difference is "text" vs "html".
There could be a if before, or a function call with the type.
Ex if you want to default to Html:
email_type = "Html"
if data_option != 'Html':
email_type = "Text"
response = client.send_email(
(...)
'Body': {
email_type: {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants