Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check remote_router and local_router in mp-peering #13

Closed
SichangHe opened this issue Jun 10, 2023 · 2 comments
Closed

Check remote_router and local_router in mp-peering #13

SichangHe opened this issue Jun 10, 2023 · 2 comments
Labels
noted Noted this in the writing question Further information is requested

Comments

@SichangHe
Copy link
Owner

https://github.com/SichangHe/parse_rpsl_policy/blob/f0ffe47c1d94163f8597c7eb57b1498c85064f06/route_policy_cmp/src/bgp/peering.rs#L36

In my understanding, the exact routers that propergated the route need to be know. We currently do not know them.

So, are we able to check these at all?

@SichangHe SichangHe added the question Further information is requested label Jun 10, 2023
@cunha
Copy link
Collaborator

cunha commented Jun 12, 2023

We could map the remote_route and local_router to AS numbers and check at least the ASN number, but you're right that we won't be able to do any checks based on the router.

(Aside: Specifying the routers is useful for building filters as that defines where routes are exported/imported.)

@SichangHe
Copy link
Owner Author

If we are not able to check these at all, I am inclined to drop these two functions.

@SichangHe SichangHe added the noted Noted this in the writing label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
noted Noted this in the writing question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants