feat: include rpc calls and outbound http requests from url parts for…

[srikanthccv]

… external metircs

Fixes SigNoz/signoz#1305
Fixes SigNoz/signoz#1300
Part SigNoz/signoz#1301

The HTTP semconv recommend setting the one of the following sets of attributes for the client HTTP requests. The client instrumentation may set any one of them. We should take that into account when deciding if the request is external.

• http.url
• http.scheme, http.host, http.target
• http.scheme, http.peer.name, net.peer.port, http.target
• http.scheme, net.peer.ip, net.peer.port, http.target

And for the RPC systems there should be rpc.{system,service,method} tuple. This is a generic requirement. For instance if you look at the AWS botocore instrumentation which is used for invoking lambdas using it's client these are set along with other FaaS attributes. This covers good number of cases but not the exhaustive list.

[ankitnayan]

@srikanthccv this won't make it work. After detecting the keys like http.url we extract the dimensions from relevant attributes to create labels which are defined at https://github.com/SigNoz/opentelemetry-collector-contrib/blob/develop/processor/signozspanmetricsprocessor/processor.go#L137-L141

As the set of attributes extracted depends on whether the call is rpc or http, we need to either define a common label key that works for both rpc and http or we define different keys for both and use different keys at querying.

According to the above decision, we will have to change our promql at the frontend api call to query_range. We need to link that issue with this so that both are merged for the feature to be effectively seen in the UI.

[srikanthccv]

@ankitnayan good catch. I didn't think about the static queries and labels. Only tested the latency_sum and latency_count. It's probably not good idea to combine everything into one. Then this also requires some new panel in UI for each different category and how they are organized. This turns out to be not as quick as I thought.

[makeavish]

LGTM @ankitnayan

[srikanthccv]

@ankitnayan please wait for me to check things with latest changes and image before merging.

[srikanthccv]

Looks like number can't repeat (now this PR has same as error_index_v2) in the schema .sql file even if the description text is not same.

[makeavish]

Yes @srikanthccv numbers can't be same in gomigrate, please update numbers to 13 as exceptions PR is already merged.