Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make SigNoz rpc aware #1366

Merged
merged 14 commits into from
Jul 14, 2022
Merged

feat: make SigNoz rpc aware #1366

merged 14 commits into from
Jul 14, 2022

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Jul 7, 2022 •
edited
Loading

Also see SigNoz/opentelemetry-collector-contrib#1308 for data model changes.

Fixes #1252

@github-actions github-actions bot added the enhancement New feature or request label Jul 7, 2022
@srikanthccv srikanthccv marked this pull request as ready for review July 8, 2022 04:33
pranshuchittora
pranshuchittora suggested changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@pranshuchittora pranshuchittora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I and @palashgdev were checking out this PR and found out one unhandled BE case.

Screenshot 2022-07-08 at 14 58 24

@srikanthccv
Copy link
Member Author

srikanthccv commented Jul 8, 2022 •
edited
Loading

@pranshuchittora some changes didn't make it to collector image earlier. Please take another look.

@makeavish
Copy link
Member

@srikanthccv
I think we should update the logic of GetFilteredSpans table too where we are using gRPC and HTTP status code, we can directly use new status code. But as we discussed we can update that in next release as we are not going ahead with migration. Creating an issue for this.

Please resolve merge conflicts. Everything else LGTM.

makeavish
makeavish previously approved these changes Jul 13, 2022
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
26.4% 26.4% Duplication

@ankitnayan ankitnayan self-requested a review July 14, 2022 04:53
@ankitnayan ankitnayan merged commit c3d665e into develop Jul 14, 2022
@ankitnayan ankitnayan deleted the issue-1252 branch July 14, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makeavish makeavish makeavish approved these changes

@ankitnayan ankitnayan ankitnayan approved these changes

@nityanandagohain nityanandagohain Awaiting requested review from nityanandagohain

@pranshuchittora pranshuchittora Awaiting requested review from pranshuchittora

@palashgdev palashgdev Awaiting requested review from palashgdev

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make SigNoz more GRPC aware
5 participants
@srikanthccv @makeavish @ankitnayan @pranshuchittora @palashgdev