-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh Button disappears for when custom filter is applied #1524
Comments
Screen.Recording.2022-08-25.at.14.10.57.mov |
Working on this |
Had a look into this issue, looks like the moment we select custom from date range, the refresh button is disabled. |
@pranay01 is this supposed to be like this as choosing a custom time range will not change past data and hence hitting refresh won't pull the latest data and hence the chart remains the same? |
@pranay01 has the team started working on this? |
@ankitnayan yes, that is applicable for just custom time range. But if we go back to And as @pranshuchittora mentioned, the refresh button also reappears when the page is refreshed. |
Not showing Refresh button when custom data range is selected is correct. But when the time is changed to
|
@fahad-frontend are you working on this or @vg18gupta can pick this up |
related #664 |
@vg18gupta assigning to you since we have not received any response form @fahad-frontend |
@ankit01-oss @pranay01 looks like the refresh button is intentionally hidden for the custom date range. |
@vg18gupta What you said is correct. But when you try to flip back to 'Last 5 min' or something like that the 'Refresh' button should re-appear right? that's not happening right now. For this to be replicated you need to select custom date range first and then flip back to pre-defined ranges. |
@sf-pchakraborty I have raised a PR, seems like there is another issue in here. Once a custom date is selected and then if we refresh the page the hidden state of the refresh button is not persisted |
Closed via: #1582 |
Please refer to the video for the issue
https://www.loom.com/share/e317482111eb44d5b3b6cb267b2ed50f
The text was updated successfully, but these errors were encountered: