Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Button disappears for when custom filter is applied #1524

Closed
ankit01-oss opened this issue Aug 19, 2022 · 14 comments
Closed

Refresh Button disappears for when custom filter is applied #1524

ankit01-oss opened this issue Aug 19, 2022 · 14 comments
Assignees
Labels

Comments

@ankit01-oss
Copy link
Collaborator

Please refer to the video for the issue

https://www.loom.com/share/e317482111eb44d5b3b6cb267b2ed50f

@pranshuchittora
Copy link
Contributor

Screen.Recording.2022-08-25.at.14.10.57.mov

@fahad-frontend
Copy link

Working on this

@sf-pchakraborty
Copy link
Contributor

Had a look into this issue, looks like the moment we select custom from date range, the refresh button is disabled.

@ankitnayan
Copy link
Collaborator

@pranay01 is this supposed to be like this as choosing a custom time range will not change past data and hence hitting refresh won't pull the latest data and hence the chart remains the same?

@vg18gupta
Copy link
Contributor

vg18gupta commented Sep 7, 2022

@pranay01 has the team started working on this?
If not, you can assign this to me

@ankit01-oss
Copy link
Collaborator Author

@ankitnayan yes, that is applicable for just custom time range. But if we go back to Last 5 min, the refresh button should come up.

And as @pranshuchittora mentioned, the refresh button also reappears when the page is refreshed.

@pranay01
Copy link
Collaborator

pranay01 commented Sep 8, 2022

Not showing Refresh button when custom data range is selected is correct. But when the time is changed to Last 5 min or something like that, then refresh button should appear

@pranay01 is this supposed to be like this as choosing a custom time range will not change past data and hence hitting refresh won't pull the latest data and hence the chart remains the same?

@ankitnayan
Copy link
Collaborator

@fahad-frontend are you working on this or @vg18gupta can pick this up

@pranay01
Copy link
Collaborator

related #664

@pranay01 pranay01 assigned vg18gupta and unassigned fahad-frontend Sep 14, 2022
@pranay01
Copy link
Collaborator

@vg18gupta assigning to you since we have not received any response form @fahad-frontend

@vg18gupta
Copy link
Contributor

@ankit01-oss @pranay01 looks like the refresh button is intentionally hidden for the custom date range.
Also not able to raise PR, can someone help me here?

@sf-pchakraborty
Copy link
Contributor

sf-pchakraborty commented Sep 20, 2022

@vg18gupta What you said is correct. But when you try to flip back to 'Last 5 min' or something like that the 'Refresh' button should re-appear right? that's not happening right now.

For this to be replicated you need to select custom date range first and then flip back to pre-defined ranges.

vg18gupta added a commit to vg18gupta/signoz that referenced this issue Sep 20, 2022
@vg18gupta
Copy link
Contributor

@sf-pchakraborty I have raised a PR, seems like there is another issue in here. Once a custom date is selected and then if we refresh the page the hidden state of the refresh button is not persisted

palashgdev added a commit that referenced this issue Sep 29, 2022
* feat: #1524 refresh button bug fix

* lint fixes

Co-authored-by: palashgdev <palashgdev@gmail.com>
@palashgdev
Copy link
Contributor

Closed via: #1582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants