Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1524 refresh button bug fix #1582

Merged
merged 5 commits into from
Sep 29, 2022
Merged

Conversation

vg18gupta
Copy link
Contributor

@vg18gupta vg18gupta commented Sep 20, 2022

@welcome
Copy link

welcome bot commented Sep 20, 2022

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@request-info
Copy link

request-info bot commented Sep 20, 2022

We would appreciate it if you could provide us with more info about this issue/pr!

@palashgdev
Copy link
Contributor

@vg18gupta can you please check build if failing maybe you can fix it by running lint:fix

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vg18gupta
Copy link
Contributor Author

@palashgdev made the lint fixes.

@palashgdev
Copy link
Contributor

Thanks @vg18gupta :-D

Copy link
Contributor

@palashgdev palashgdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palashgdev palashgdev merged commit 9e99249 into SigNoz:develop Sep 29, 2022
@welcome
Copy link

welcome bot commented Sep 29, 2022

Congrats on merging your first pull request!
minion-party
We here at SigNoz are proud of you! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants