Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Exported dashboard include response of the queries #1981

Closed
prashant-shahi opened this issue Jan 4, 2023 · 0 comments
Closed

FE: Exported dashboard include response of the queries #1981

prashant-shahi opened this issue Jan 4, 2023 · 0 comments
Assignees

Comments

@prashant-shahi
Copy link
Member

Bug description

When existing dashboard is exported, we see that it includes response of the queries i.e. metric labels and values..

Expected behavior

Ideally, we should clean up those values as it could be sensitive data for users. Removing those will make sure to keep them safe if they decide to share their dashboard with someone else.

Example of cleaned queryData under widgets array:

{
      "queryData": {
        "data": {
          "queryData": []
        },
        "error": false,
        "errorMessage": "",
        "loading": false
      }
}

How to reproduce

  1. Create a dashboard with multiple widgets or import hostmetrics dashboard
  2. Make sure that it plots some data
  3. Export the dashboard JSON and inspect it

Version information

  • Signoz version: v0.13.0
  • Browser version: Chromium
  • Your OS and version: Linux
  • Your CPU Architecture(ARM/Intel): AMD64

Additional context

NA

prashant-shahi pushed a commit that referenced this issue Jan 30, 2023
* clear the queryData
* avoid creation of inline func and move logic to utils
* remove console.log
* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants