FIX: Exported dashboard include response of the queries #1981 #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palashgdev
suggested changes
Jan 16, 2023
frontend/src/container/NewDashboard/DescriptionOfDashboard/ShareModal.tsx
Show resolved
Hide resolved
frontend/src/container/NewDashboard/DescriptionOfDashboard/ShareModal.tsx
Outdated
Show resolved
Hide resolved
palashgdev
suggested changes
Jan 25, 2023
frontend/src/container/NewDashboard/DescriptionOfDashboard/ShareModal.tsx
Outdated
Show resolved
Hide resolved
|
Apart from this one PR looks good to me ,Thanks for raising the PR @FellipeMTX :-D |
FellipeMTX
requested review from
srikanthccv,
prashant-shahi and
ankitnayan
as code owners
FellipeMTX
force-pushed
the
SIGNOZ-1981
branch
from
17c66e0
to
9c02f17
Compare
FellipeMTX
requested review from
palashgdev
and removed request for
prashant-shahi,
ankitnayan,
srikanthccv and
palashgdev
|
SonarCloud Quality Gate failed.
|
palashgdev
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue solved: #1981
I created a new ''const'' according to the issue's request and set this const to be the parameter of the download function. I had trouble reproducing the error, but I think this solution should work.
Image of console.log of new const(which will be downloaded):