Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docs to install SQLite3 #1924

Merged
merged 11 commits into from
Jan 4, 2023
Merged

Conversation

axaysagathiya
Copy link
Contributor

Added commands to install sqlite3 in Makefile.

Closes #1923

prashant-shahi
prashant-shahi previously approved these changes Dec 28, 2022
Copy link
Member

@prashant-shahi prashant-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Makefile Outdated Show resolved Hide resolved
@pranay01 pranay01 added this to the v0.14.0 milestone Dec 30, 2022
prashant-shahi
prashant-shahi previously approved these changes Dec 30, 2022
@makeavish makeavish self-requested a review January 2, 2023 11:21
Copy link
Member

@makeavish makeavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note for other non-ubuntu/debain OS to install SQLite

@axaysagathiya axaysagathiya changed the title add commands to install sqlite3 in Makefile. Add Docs to install SQLite3 Jan 4, 2023
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ankitnayan ankitnayan merged commit b776bf5 into SigNoz:develop Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command sudo make dev-setup gives Error if sqlite3 is not installed already in a system.
6 participants