Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error check in unit tests. #1993

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Add error check in unit tests. #1993

merged 3 commits into from
Feb 6, 2023

Conversation

axaysagathiya
Copy link
Contributor

Added error check in below unit tests

  • TestGenerateSQLQuery
  • TestReplaceInterestingFields
  • TestParseColumn
  • TestParseLogQueryCorrect

Closes #1992

@srikanthccv
Copy link
Member

Please resolve conflicts

nityanandagohain
nityanandagohain reviewed Jan 18, 2023
View reviewed changes
pkg/query-service/app/logs/parser_test.go Outdated Show resolved Hide resolved
pkg/query-service/app/logs/parser_test.go Outdated Show resolved Hide resolved
pkg/query-service/app/logs/parser_test.go Outdated Show resolved Hide resolved
pkg/query-service/app/logs/parser_test.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@srikanthccv srikanthccv merged commit f7ff491 into SigNoz:develop Feb 6, 2023
@srikanthccv
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@nityanandagohain nityanandagohain nityanandagohain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add error check in unit test.
3 participants
@axaysagathiya @srikanthccv @nityanandagohain