Fix: Different time formats in hover legend and x-axis on charts #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
gitstart
changed the title
palashgdev
suggested changes
Jan 13, 2023
|
Hi @gitstart |
gitstart
force-pushed
the
SGNZOSS-5
branch
2 times, most recently
from
c060b83
to
454d541
Compare
gitstart
commented
Jan 17, 2023
|
Hi @palashgdev, PR has been updated please take a look |
|
Look at this for example https://play.grafana.org/d/000000012/grafana-play-home?orgId=1 |
|
Hi @srikanthccv! Just want to confirm before pushing changes, does this work? |
gitstart
force-pushed
the
SGNZOSS-5
branch
2 times, most recently
from
7ae2a60
to
066a2c6
Compare
Co-authored-by: niteshsingh1357 <niteshsingh1357@gmail.com> Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by: gitstart <gitstart@users.noreply.github.com> Co-authored-by: gitstart-app[bot] <57568882+gitstart-app[bot]@users.noreply.github.com> Co-authored-by: Rafael <rafael.toledo@engenharia.ufjf.br> Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
gitstart
requested review from
srikanthccv
and removed request for
palashgdev
|
Kudos, SonarCloud Quality Gate passed!
|
palashgdev
approved these changes
Feb 1, 2023
|
Thanks @gitstart and sorry for the confusion :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #892
Demo: https://www.loom.com/share/87acb03a2e5e4b8c986ff3916fdc2480