Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add list and table views for logs #2163

Merged
merged 26 commits into from
Feb 15, 2023
Merged

feat: add list and table views for logs #2163

merged 26 commits into from
Feb 15, 2023

Conversation

volodfast
Copy link
Contributor

@volodfast volodfast commented Feb 1, 2023 •
edited by palashgdev
Loading

Close #1848

@volodfast volodfast self-assigned this Feb 1, 2023
@request-info
Copy link

request-info bot commented Feb 1, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

palashgdev
palashgdev previously approved these changes Feb 3, 2023
View reviewed changes
@palashgdev palashgdev self-requested a review February 3, 2023 14:38
palashgdev
palashgdev previously approved these changes Feb 3, 2023
View reviewed changes
@palashgdev palashgdev added this to the v0.16.0 milestone Feb 6, 2023
@nityanandagohain nityanandagohain mentioned this pull request Feb 7, 2023
Closed
nityanandagohain
nityanandagohain reviewed Feb 7, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Font of raw view should be changed.
  • While hovering over a raw log line, I don't think a popup is expected or is it ?

nityanandagohain
nityanandagohain reviewed Feb 7, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Convert interesting to selected field and vice versa, the table UI doesn't update. Have to manually refresh the page.

nityanandagohain
nityanandagohain reviewed Feb 7, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In the table view, when I add many selected fields, to scroll horizontally I have to go down to the bottom of the page, which is not ideal experience
  • Columns in table are not resizable in table view

@palashgdev palashgdev removed this from the v0.16.0 milestone Feb 7, 2023
nityanandagohain
nityanandagohain previously approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

palashgdev
palashgdev previously approved these changes Feb 15, 2023
View reviewed changes
@palashgdev palashgdev dismissed stale reviews from nityanandagohain and themself via bad74f7 February 15, 2023 08:58
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.0% 3.0% Duplication

@palashgdev palashgdev self-requested a review February 15, 2023 09:24
@palashgdev palashgdev merged commit bad80de into SigNoz:develop Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashgdev palashgdev palashgdev approved these changes

@nityanandagohain nityanandagohain nityanandagohain left review comments

@ankitnayan ankitnayan Awaiting requested review from ankitnayan

Assignees

@volodfast volodfast

Labels
request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compact and/or customisable log view layout
6 participants
@volodfast @nityanandagohain @palashgdev @pranay01 @makeavish @techchintan