Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filters applied in the logs page #2210

Merged
merged 8 commits into from
Feb 11, 2023
Merged

fix: filters applied in the logs page #2210

merged 8 commits into from
Feb 11, 2023

Conversation

KolesnikAntony
Copy link
Contributor

Close #2208

@KolesnikAntony KolesnikAntony added the bug Something isn't working label Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

palashgdev
palashgdev suggested changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@palashgdev palashgdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.loom.com/share/c477438a41c745709ee60220b800c44a

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@palashgdev palashgdev self-requested a review February 10, 2023 14:49
palashgdev
palashgdev suggested changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@palashgdev palashgdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KolesnikAntony i guess query is not parsed correctly

Screenshot 2023-02-10 at 8 20 29 PM

Screenshot 2023-02-10 at 8 20 37 PM

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@palashgdev palashgdev self-requested a review February 11, 2023 03:09
@palashgdev palashgdev merged commit 93b6749 into develop Feb 11, 2023
@welcome
Copy link

welcome bot commented Feb 11, 2023

Congrats on merging your first pull request!
minion-party
We here at SigNoz are proud of you! 🥳

@srikanthccv srikanthccv deleted the bug/issue-2208 branch January 4, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashgdev palashgdev palashgdev approved these changes

Assignees

@KolesnikAntony KolesnikAntony

Labels
bug Something isn't working codeball:needs-careful-review Codeball
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FE: filters applied in the logs page
2 participants
@KolesnikAntony @palashgdev