fix: changed ask admin message #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
srikanthccv
reviewed
Feb 10, 2023
|
@mindhash there is one conflict can you please resolve that ... apart from that this PR looks |
srikanthccv
reviewed
Feb 24, 2023
srikanthccv
reviewed
Feb 24, 2023
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
|
SonarCloud Quality Gate failed.
|
palashgdev
approved these changes
Feb 24, 2023
srikanthccv
approved these changes
Feb 24, 2023
ankitnayan
approved these changes
Feb 24, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue# 2206
Changes:
Update:
Added a new SetupComplete flag to indicate that the first user has signed up. The flag is an indicator that signoz has been setup. And from this point on, we disable self-register option for users. Only invite token based sign-up would be supported.
The UI redirects user to sign-up page incase no user is setup yet. This means, when you install signoz for the first time and go to https://> you will be redirected to https://>/signup. If the first user is already setup then, login page would be shown (note: existing cases would continue to work like if user is already logged in, then no login will be prompted instead user will go to app home, etc).
The messaging "If you are admin, create an account" has been removed.