Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pop!OS support (same as ubuntu) #2417 #2420

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Pop!OS support (same as ubuntu) #2417 #2420

merged 3 commits into from
Mar 9, 2023

Conversation

adderek
Copy link
Contributor

@adderek adderek commented Mar 3, 2023

Pop!OS is based on Ubuntu, Ubuntu is based on Debian.
This simply adds support for Pop!OS as Ubuntu.

@welcome
Copy link

welcome bot commented Mar 3, 2023

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@makeavish makeavish linked an issue Mar 9, 2023 that may be closed by this pull request
Pop!OS support (same as ubuntu) #2417
Closed
@makeavish makeavish modified the milestone: v0.17.0 Mar 9, 2023
@adderek
Copy link
Contributor Author

adderek commented Mar 9, 2023

@makeavish how this build can be failing if it only adds extra "or" to a condition and is not affecting logic in any other way? That's probably nothing I can fix myself

@makeavish
Copy link
Member

@adderek Builds are not failing, exactly which build are you referring to?

@adderek
Copy link
Contributor Author

adderek commented Mar 9, 2023

@adderek Builds are not failing, exactly which build are you referring to?

Some checks were not successful
4 failing and 9 successful checks

Checks.

@makeavish
Copy link
Member

@adderek Some checks are not necessary and playwright tests haven't been updated. So it's fine.

@prashant-shahi prashant-shahi merged commit 59497ed into SigNoz:develop Mar 9, 2023
@welcome
Copy link

welcome bot commented Mar 9, 2023

Congrats on merging your first pull request!
minion-party
We here at SigNoz are proud of you! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makeavish makeavish makeavish approved these changes

@prashant-shahi prashant-shahi prashant-shahi approved these changes

@palashgdev palashgdev palashgdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pop!OS support (same as ubuntu)
4 participants
@adderek @makeavish @prashant-shahi @palashgdev