Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop!OS support (same as ubuntu) #2417

Closed
adderek opened this issue Mar 2, 2023 · 2 comments · Fixed by #2420
Closed

Pop!OS support (same as ubuntu) #2417

adderek opened this issue Mar 2, 2023 · 2 comments · Fixed by #2420
Assignees

Comments

@adderek
Copy link
Contributor

adderek commented Mar 2, 2023

Is your feature request related to a problem?

Yes - on Pop!OS it works but is unable to detect it correctly.

Please describe.
Pop!OS is based on Ubuntu.
Ubuntu is based on Debian.
It is possible to use either dpkg or apt/apt-get.

Describe the solution you'd like

Just change deploy/install.sh:

    case "$os_name" in
        #Ubuntu*)
        Ubuntu*|Pop!_OS)

Describe alternatives you've considered

Separate entry for Pop!OS. To fork and patch, then pull request but let's signoz decide which solution might be the best.

Additional context

Add any other context or screenshots about the feature request here.

I had docker.io installed (but it has no docker-compose). Install script was unable to install it. Simple apt install docker-compose was enough to solve the problem.

Thank you for your feature request – we love each and every one!

@welcome
Copy link

welcome bot commented Mar 2, 2023

Thanks for opening this issue. A team member should give feedback soon. In the meantime, feel free to check out the contributing guidelines.

@makeavish
Copy link
Member

Thanks for creating an issue @adderek.
It would be great if you can create a PR with the solution you proposed.

adderek added a commit to adderek/signoz that referenced this issue Mar 3, 2023
@makeavish makeavish linked a pull request Mar 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants