Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clear filter is fixed #2544

Merged
merged 11 commits into from
Apr 20, 2023
Merged

fix: clear filter is fixed #2544

merged 11 commits into from
Apr 20, 2023

Conversation

palashgdev
Copy link
Contributor

Close #2543

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added bug Something isn't working codeball:approved Codeball labels Apr 4, 2023
github-actions[bot]
github-actions bot previously approved these changes Apr 4, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.94 | [dashboard]

@palashgdev palashgdev marked this pull request as draft April 4, 2023 06:52
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@palashgdev palashgdev marked this pull request as ready for review April 5, 2023 11:38
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@palashgdev palashgdev merged commit 6c11c6d into develop Apr 20, 2023
@palashgdev palashgdev deleted the 2543 branch April 20, 2023 11:58
prashant-shahi pushed a commit that referenced this pull request Apr 21, 2023
@palashgdev @prashant-shahi
fix: clear filter is fixed (#2544)
c49bb06 
* fix: clear filter is fixed

* chore: action bar empty query condition is handled

* feat: local state is clear for filters

(cherry picked from commit 6c11c6d)
Signed-off-by: Prashant Shahi <prashant@signoz.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nityanandagohain nityanandagohain nityanandagohain approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@nityanandagohain nityanandagohain

Labels
bug Something isn't working codeball:needs-careful-review Codeball
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logs(FE): Clear filter is not working as expected
2 participants
@palashgdev @nityanandagohain