-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issues on WHERE search filter #2629
fix: issues on WHERE search filter #2629
Conversation
…ssue-search-filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small change... though working fine from functionality perspective
frontend/src/container/QueryBuilder/filters/QueryBuilderSearch/index.tsx
Show resolved
Hide resolved
@techchintan please incorporate the changes from this commit b91a13e. And I noticed the value of the query params is incorrect for the
|
I do not think the first point is addressed probably related to incorrect query param. The key-op-value flow is not starting unless the aggregate attribute is chosen. |
ec38198
to
4f0a545
Compare
…/signoz into fix/issue-search-filter
frontend/src/container/QueryBuilder/filters/QueryBuilderSearch/utils.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be taking the feedback in another as functionality is working fine
Close: Point 3: - Filter - #2353 (comment)
Except for Subpoint - 4 & 6