Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues on WHERE search filter #2629

Merged
merged 119 commits into from
May 12, 2023

Conversation

techchintan
Copy link
Contributor

@techchintan techchintan commented Apr 25, 2023

Close: Point 3: - Filter - #2353 (comment)
Except for Subpoint - 4 & 6

Copy link
Contributor

@palashgdev palashgdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change... though working fine from functionality perspective

@srikanthccv
Copy link
Member

@techchintan please incorporate the changes from this commit b91a13e.

And I noticed the value of the query params is incorrect for the /attribute_values API. Here is what each of them means. This was working earlier.

  • aggregateOperator: aggregation operator selected from the list of aggregations supported for each signal.
  • dataSource: one of the data sources selected from logs, traces, and metrics.
  • aggregateAttribute: aggregation attribute key selected
  • attributeKey: The key from the where clause the user has typed. (where keys are fetched from /attribute_keys API)
  • tagType: tag type of the key from the where clause the user has typed. (/attribute_keys would have also provided the tag type, that should be used here, null in case of a custom key)
  • filterAttributeKeyDataType: data type of the key from the where clause user has typed. (/attribute_keys would have also provided the data type, that should be used here, null in case of a custom key)
  • searchText: search text for the value

@srikanthccv
Copy link
Member

I do not think the first point is addressed probably related to incorrect query param. The key-op-value flow is not starting unless the aggregate attribute is chosen.

Copy link
Contributor

@palashgdev palashgdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be taking the feedback in another as functionality is working fine

@palashgdev palashgdev merged commit 7633100 into SigNoz:develop May 12, 2023
6 of 9 checks passed
@techchintan techchintan deleted the fix/issue-search-filter branch May 16, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants