fix: issue of new query builder v3 #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would appreciate it if you could provide us with more info about this issue/pr! |
srikanthccv
reviewed
May 16, 2023
frontend/src/container/QueryBuilder/filters/AggregateEveryFilter/index.tsx
Outdated
Show resolved
Hide resolved
frontend/src/container/QueryBuilder/filters/HavingFilter/HavingFilter.tsx
Outdated
Show resolved
Hide resolved
| })), | ||
| ); | ||
| newOptions = results.map((item) => ({ | ||
| label: checkCommaInValue(String(item)), |
There was a problem hiding this comment.
What is this checkCommaInValue? We shouldn't use naive string manipulations anywhere in the code. I have already suggested a fix here #2629 (comment)
There was a problem hiding this comment.
This still needs to be fixed
|
|
…udani7/signoz into fix-issue/new-querybuilder-v3
ankitnayan
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.