Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: limit default value is updated #2805

Merged
merged 3 commits into from
Jun 1, 2023
Merged

fix: limit default value is updated #2805

merged 3 commits into from
Jun 1, 2023

Conversation

palashgdev
Copy link
Contributor

on null limit value is reflected as empty not 1

@github-actions github-actions bot added the bug Something isn't working label May 31, 2023
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@palashgdev palashgdev requested a review from yeshev May 31, 2023 12:25
srikanthccv
srikanthccv approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will test this along with other changes.

@srikanthccv srikanthccv merged commit c69e2e0 into develop Jun 1, 2023
@srikanthccv srikanthccv deleted the fix/limit branch June 1, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@yeshev yeshev Awaiting requested review from yeshev

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palashgdev @srikanthccv