Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: alert evaluation params and query #3010

Merged
merged 3 commits into from
Jul 5, 2023
Merged

fix: alert evaluation params and query #3010

merged 3 commits into from
Jul 5, 2023

Conversation

srikanthccv
Copy link
Member

  1. Update the rate query to not generate intermediary +inf value when the denominator is zero
  2. Adjust the start and end time to incorporate data in movement
  3. Round the start and end to minute
  4. Add log to find the exact query that triggered alert for troubleshooting ;

@srikanthccv
fix: alert evaluation params and query
40d7944 
1. Update the rate query to not generate intermediary +inf value when the denominator is zero
2. Adjust the start and end time to incorporate data in movement
3. Round the start and end to minute
4. Add log to find the exact query that triggered alert for troubleshooting
;
@github-actions github-actions bot added the bug Something isn't working label Jul 2, 2023
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv srikanthccv marked this pull request as ready for review July 3, 2023 07:59
@srikanthccv
Copy link
Member Author

@mindhash @ankitnayan leave an approval if there are no concerns.

ankitnayan
ankitnayan previously approved these changes Jul 4, 2023
View reviewed changes
@ankitnayan
Copy link
Collaborator

@mindhash @ankitnayan leave an approval if there are no concerns.

@srikanthccv the build-query-service build has failed. Have a look

@srikanthccv
Copy link
Member Author

Fixed a failing test. PTAL

@ankitnayan ankitnayan self-requested a review July 5, 2023 05:03
@ankitnayan ankitnayan merged commit b8aba4f into develop Jul 5, 2023
7 of 8 checks passed
@ankitnayan ankitnayan deleted the fix-alerts-obsrv branch July 5, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mindhash mindhash mindhash left review comments

@ankitnayan ankitnayan ankitnayan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srikanthccv @ankitnayan @mindhash