Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [GH-3790]: timerange not working for different users #4192

Merged
merged 7 commits into from
Dec 14, 2023
Merged

fix: [GH-3790]: timerange not working for different users #4192

merged 7 commits into from
Dec 14, 2023

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Dec 8, 2023 •
edited
Loading

Summary

  • the startTime and endTime were not getting populated in the URL hence the sharing of timezones were not working for different users
  • Now if one user selects some time range and opens it up in different tab OR shares it to a different user , they will see the time range exactly which was being used while sharing the URL

Related Issues / PR's

This resolves #3790

Screenshots

Screen.Recording.2023-12-13.at.11.22.47.PM.mov

Affected Areas and Manually Tested Areas

palashgdev
palashgdev previously approved these changes Dec 14, 2023
View reviewed changes
@YounixM YounixM merged commit 7efe907 into SigNoz:develop Dec 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@palashgdev palashgdev palashgdev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FE: Timerange is not working on URL
3 participants
@vikrantgupta25 @YounixM @palashgdev