WIP : feat: replace ant design spinner and add color prop for customization #5401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahmadshaheer jest tests needs to be updated according to the new spinner, build is failing. |
YounixM
reviewed
Jul 2, 2024
YounixM
previously approved these changes
Jul 2, 2024
SagarRajput-7
previously approved these changes
Jul 2, 2024
SagarRajput-7
approved these changes
Jul 8, 2024
YounixM
approved these changes
Jul 10, 2024
ahmadshaheer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / PR's
close #5281
Screenshots
Before:
https://www.loom.com/share/195cd91c949f48e0baa7ac00b293e812
After:
https://www.loom.com/share/c8fd4c60e97e4098958da8588c8cf2aa
Affected Areas and Manually Tested Areas