Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added trace views test #5519

Merged
merged 18 commits into from
Aug 29, 2024
Merged

chore: added trace views test #5519

merged 18 commits into from
Aug 29, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Jul 18, 2024

Summary

  • Test cases covered:

    • should render the SaveView component
    • explorer icon should take the user to the related explorer page
    • should render the SaveView component with a search input
    • should be able to edit name of view
    • should be able to delete a view
    • should render empty state
  • Also included complex E2E in playwright - here - https://github.com/SigNoz/signoz-e2e/pull/5

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 force-pushed the trace-views-test branch 2 times, most recently from 28c6f32 to 1499812 Compare July 22, 2024 05:57
ahmadshaheer
ahmadshaheer previously approved these changes Jul 24, 2024
ahmadshaheer
ahmadshaheer previously approved these changes Jul 31, 2024
YounixM
YounixM previously approved these changes Aug 21, 2024
@SagarRajput-7 SagarRajput-7 merged commit 2f0d98a into develop Aug 29, 2024
11 of 12 checks passed
@SagarRajput-7 SagarRajput-7 deleted the trace-views-test branch August 29, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants