Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean out the logs time range issues / old logs explorer routes issue #5590

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Jul 29, 2024

Summary

  • removed the timeRange object from the URL. this was causing confusion and issues with the custom time ranges and the relative time ranges in the logs.
  • rely on the global state of time for everything as that is our source of truth and the trigger for the APIs as well.
  • copy log link should also work on the concept of startTime , endTime rather than the timeRange object. the activeLogId remains as is.
  • Updated the permissions to access the old logs explorer page to similar as new logs explorer page as it wasn't working on reload or sharing the URL
  • updated the fontSize for the old logs explorer page to be in sync with new logs explorer page giving the users a uniform view.

Related Issues / PR's

fixes - #4820

fixes - https://github.com/SigNoz/engineering-pod/issues/1486

Screenshots

NA

Affected Areas and Manually Tested Areas

  • Relative and Custom time with the new logs explorer page ( sharing the same with absolute toggle on and off )
  • Drag and Drop in the time series graph and then sharing the URLs
  • Reload on the old logs explorer page and sharing the URL.
  • format of font size on the old and new logs to be in sync

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

SagarRajput-7
SagarRajput-7 previously approved these changes Aug 22, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 changed the title chore: clean out the logs time range async issues chore: clean out the logs time range issues / old logs explorer routes issue Aug 26, 2024
@vikrantgupta25 vikrantgupta25 merged commit c2f607a into develop Aug 26, 2024
14 of 16 checks passed
@vikrantgupta25 vikrantgupta25 deleted the clean-logs-timerange branch August 26, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants