Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard names invisible due to same background color #5758

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

YounixM
Copy link
Collaborator

@YounixM YounixM commented Aug 23, 2024

Summary

Issue:
Screenshot 2024-08-22 at 10 21 50 PM

After:
Screenshot 2024-08-23 at 11 45 54 AM

Screenshot 2024-08-23 at 11 46 07 AM Screenshot 2024-08-23 at 11 48 37 AM

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Aug 23, 2024
@ankitnayan
Copy link
Collaborator

Do we know which PR caused this? Else maybe this PR causes the other PR to break UI for which this was put in place

@YounixM
Copy link
Collaborator Author

YounixM commented Aug 23, 2024

@ankitnayan : The dark mode styles had more specificity and hence dark mode color gets applied. In this PR, we have updated lightMode specific color only, hence it won't revert the other change.

@YounixM
Copy link
Collaborator Author

YounixM commented Aug 23, 2024

https://github.com/SigNoz/signoz/pull/5672/files

frontend/src/container/ListOfDashboard/DashboardList.styles.scss

Line 78:

.title {
	color: var(--bg-vanilla-100);
	font-size: var(--font-size-sm);
	font-style: normal;
	font-weight: var(--font-weight-medium);
	line-height: 20px;
	letter-spacing: -0.07px;

	display: -webkit-box;
	-webkit-line-clamp: 3;
	-webkit-box-orient: vertical;
	overflow: hidden;
}

This style was more specific and the styles got applied.

@ankitnayan
Copy link
Collaborator

ok

@vikrantgupta25 vikrantgupta25 merged commit 43ed49f into develop Aug 23, 2024
11 of 12 checks passed
@vikrantgupta25 vikrantgupta25 deleted the fix/dashboards-list-view-light-mode branch August 23, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants