Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable macro #5760

Merged
merged 1 commit into from
Aug 26, 2024
Merged

feat: enable macro #5760

merged 1 commit into from
Aug 26, 2024

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Aug 23, 2024 •
edited
Loading

P.R to enable macro, This will be needed w.r.t new schema

@nityanandagohain nityanandagohain requested a review from a team as a code owner August 23, 2024 13:12
@github-actions github-actions bot added the enhancement New feature or request label Aug 23, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

srikanthccv
srikanthccv approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it clear it in the next release notes that people should enable macros in their docker setups. Some existing OSS users don't use our deploy rather they maintain their own and copy changes when required.

@nityanandagohain
Copy link
Member Author

Yeah will add it to the release notes . cc @prashant-shahi

@nityanandagohain nityanandagohain merged commit 9f481aa into develop Aug 26, 2024
10 of 13 checks passed
@nityanandagohain nityanandagohain deleted the feat/enable_macro_1 branch August 26, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nityanandagohain @srikanthccv