Fix various JSON input bugs #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nponeccop
previously approved these changes
Apr 10, 2023
|
@Torantulino Can you merge it? |
|
@STRML Conflicts again. |
|
@nponeccop Looks like the ValueError catch was added to |
By not having correct_json(json_str) in the try/except, it was still easily possible to throw Invalid JSON errors. When responses were received with no JSON at all, parsing would fail on attempting to locate the braces.
nponeccop
approved these changes
Apr 12, 2023
richbeales
approved these changes
Apr 12, 2023
SquareandCompass
pushed a commit
to SquareandCompass/Auto-GPT
that referenced
this pull request
Oct 21, 2023
…#685) * check config constraints for the initial config * default config value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I was receiving an
Invalid JSONerror on pretty much every prompt. Once it was received, it was very difficult to get out of it.Changes
By not having correct_json(json_str) in the try/except, it was still easily possible to throw Invalid JSON errors.
When responses were received with no JSON at all, parsing would fail on attempting to locate the braces.
Test Plan
Tested by running a bunch of prompts. Sorry it's not more scientific than that. Each time I got a parsing error, I added a fix, and now it seems stable.
PR Quality Checklist