Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Portlets] closing feature #9549 #858

Closed
wants to merge 1 commit into from
Closed

[Portlets] closing feature #9549 #858

wants to merge 1 commit into from

Conversation

NicolasEYSSERIC
Copy link
Member

No description provided.

silveruser
silveruser reviewed Feb 12, 2018
View reviewed changes
core-war/src/main/java/org/silverpeas/web/portlets/ComponentInstancePortlet.java

import javax.portlet.*;
import java.io.IOException;

public class ComponentInstancePortlet extends GenericPortlet implements FormNames {

private static String PREFINSTANCEID = "instanceId";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Rename this field "PREFINSTANCEID" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

@silveruser
Copy link
Contributor

SonarQube analysis reported 1 issue

  • MINOR 1 minor

Watch the comments in this conversation to review them.

@SilverYoCha SilverYoCha self-assigned this Feb 13, 2018
@SilverYoCha
Copy link
Member

Merged.
Closed manually because of manual git operations performed during integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silveruser silveruser silveruser left review comments

Assignees

@SilverYoCha SilverYoCha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasEYSSERIC @silveruser @SilverYoCha