Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] ROS: Activate prerelease #181

Merged

Conversation

wxmerkt
Copy link
Contributor

@wxmerkt wxmerkt commented Feb 21, 2023

To check if we could move to packaging/vendoring

@jcarpent
Copy link
Member

@wxmerkt It seems that CMAKE_ARGS is not parsed by the CI. Do you know why?

@wxmerkt
Copy link
Contributor Author

wxmerkt commented Feb 23, 2023

I believe it's because this is a PRERELEASE build that would require a different kind of patching (in a release repo). The idea was to check with this if we are ready to package/distribute via the ROS buildfarm as requested in #178 but I got very busy so didn't have more time to investigate or add a solution - one way to do this is to quickly address it is to check if simde is available in QUIET/CONFIG mode, warn if vectorisation is on and simde not found, and then turn vectorisation off. Would this be workable? This would avoid patching but still keep users informed that if they want vectorisation they need to provide the package.

Alternatively, we can think about (a) vendoring simde to 20.04/noetic or (b) falling back to an ExternalProject/FetchContent since it's header-only [but then would need to install it which isn't ideal]

If you are interested in packaging/distributing via the ROS buildfarm, please let me know and I could look into this more closely next week - alternatively also happy to close the PR for now and come back to it later

@wep21
Copy link
Contributor

wep21 commented Feb 24, 2023

@wxmerkt @jcarpent Is it possible to release to ros2-gbp first? I guess it is ready for ros2 release.

@jcarpent
Copy link
Member

@wxmerkt @wep21 What are the next steps? Should we enable ccache?

@wxmerkt
Copy link
Contributor Author

wxmerkt commented Feb 25, 2023

I turned off ccache since it appears to cause the issues with prerelease we've been seeing with ci@master.

As for next steps, if you are happy we'd merge this branch and then can request a ros2-gbp release repository. If you'd like to distribute via the ROS buildfarm I'm happy to help out. The plan would be rolling first (to test), then humble. For ROS1/noetic, we need to first vendor simde. Please let me know what your thoughts / plans are

@wep21: Do you have an application/package in mind that would use proxsuite so we can enable downstream tests / verify the binaries once they are released?

A good first test would be to try tsid with proxsuite on ROS2. Perhaps @olivier-stasse already looked into something like this (or has other ROS2 use cases in mind) that we could use to validate the packages?

@jcarpent jcarpent merged commit 4e85663 into Simple-Robotics:devel Feb 25, 2023
@jcarpent
Copy link
Member

As for next steps, if you are happy we'd merge this branch and then can request a ros2-gbp release repository.

Do you need a new release for that?

@wxmerkt
Copy link
Contributor Author

wxmerkt commented Feb 25, 2023

@jcarpent Yes please :-)

@jcarpent
Copy link
Member

jcarpent commented Feb 25, 2023

@wxmerkt The release is out. Thanks a lot for your efforts @wxmerkt @wep21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants