DOC: Improving documentation based on user input. #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improving the build documentation based on user input from this discourse discussion: https://discourse.itk.org/t/using-cmake-to-build-simpleitk/373 Change-Id: Ifbcda487d58128e88c37ba21606448b26a6aa6c9
|
This is a good start but I think we need command line instruction that will work in a copy and paste way for MS Windows. Specifically, the build command have a path that is too long, and we should instruct using |
blowekamp
reviewed
Nov 20, 2017
|
|
||
| Words of caution for building on the Windows operating system: | ||
|
|
||
| * Visual studio has issues with long directory paths, we recommend cloning the |
There was a problem hiding this comment.
We should be more general here and just say, "Microsoft Windows has issues with"...
Previously said that "Visual studio has issues with long directory paths...". This is a windows issue not specific to the visual studio compiler, other compilers have the same problem. Change-Id: I3dc7b7d13beb7330729dd0becbb3a6313c1e3331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving the build documentation based on user input from this
discourse discussion:
https://discourse.itk.org/t/using-cmake-to-build-simpleitk/373
Change-Id: Ifbcda487d58128e88c37ba21606448b26a6aa6c9