Add renamed const buffer access methods to C# interface. #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blowekamp
force-pushed
the
AddConstBufferMethodForCSharp
branch
from
df74b21
to
2f78607
Compare
|
I've tested this fix and it works. This resolves the problems raised in issue #961. |
dave3d
reviewed
Feb 3, 2020
| @@ -43,6 +43,24 @@ | |||
| %CSharpTypemapHelper( float*, System.IntPtr ) | |||
| %CSharpTypemapHelper( double*, System.IntPtr ) | |||
|
|
|||
|
|
|||
| // CSharp does not hadle overloaded const methods. So they are | |||
blowekamp
force-pushed
the
AddConstBufferMethodForCSharp
branch
from
2f78607
to
cec52f2
Compare
zivy
approved these changes
Feb 4, 2020
| // explicitly renamed to enable their explicit usage. These methods | ||
| // assume that the buffer is will not be modified, so MakeUnique is | ||
| // not call. | ||
| %rename("GetConstBufferAsInt8") itk::simple::Image::GetBufferAsInt8( ) const; |
There was a problem hiding this comment.
// assume that the buffer is will not be modified, so MakeUnique is
// not call.
change to:
// assume that the buffer will not be modified, so MakeUnique is
// not called.
The implicit modification of the sitk::Image by calling MakeUnique in the GetBufferAs.. methods can cause problem in with multi-threader. See issue SimpleITK#958 for more details.
blowekamp
force-pushed
the
AddConstBufferMethodForCSharp
branch
from
cec52f2
to
8054ae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implicit modification of the image by calling MakeUnique can cause
problem in with multi-threader. See issue #958 for more details.