Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL support #751

Open
karmac2015 opened this Issue Jan 10, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@karmac2015
Copy link
Contributor

karmac2015 commented Jan 10, 2019

Hello, I like your very nice apps, But I think if you support RTL layout it should be better.

@jtj9817

This comment has been minimized.

Copy link
Contributor

jtj9817 commented Jan 20, 2019

Hey @tibbi , can I take this issue? I will probably need guidance on implementing the RTL support since it will require changing quite a number of layouts but I'll try to work on what I can.

@tibbi

This comment has been minimized.

Copy link
Member

tibbi commented Jan 20, 2019

sure, well it mostly consists of changing things like "marginLeft" to "marginStart". For easy testing you can enable forced RTL layout at your devices developer settings, while still having english language set.

@karmac2015

This comment has been minimized.

Copy link
Contributor Author

karmac2015 commented Jan 21, 2019

Hello, @jtj9817 I have finished modifying the project Simple-Contacts to support RTL, take a look at the changes I have made here

@jtj9817

This comment has been minimized.

Copy link
Contributor

jtj9817 commented Jan 21, 2019

Hey @karmac2015 , thanks for the reference code. I'm sure I will find it helpful and I'll take a look at it.

jtj9817 added a commit to jtj9817/Simple-Calendar that referenced this issue Jan 25, 2019

Phase One for issue SimpleMobileTools#751
Refactored code for XML layout files involved for adding RTL support

tibbi added a commit that referenced this issue Jan 26, 2019

Merge pull request #762 from jtj9817/master
Phase One for RTL Support #751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.