Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL support #751

Open
karmac2015 opened this issue Jan 10, 2019 · 8 comments
Open

RTL support #751

karmac2015 opened this issue Jan 10, 2019 · 8 comments
Labels
feature request

Comments

@karmac2015
Copy link
Contributor

Hello, I like your very nice apps, But I think if you support RTL layout it should be better.
@jtj9817
Copy link
Contributor

jtj9817 commented Jan 20, 2019

Hey @tibbi , can I take this issue? I will probably need guidance on implementing the RTL support since it will require changing quite a number of layouts but I'll try to work on what I can.

@tibbi
Copy link
Member

tibbi commented Jan 20, 2019

sure, well it mostly consists of changing things like "marginLeft" to "marginStart". For easy testing you can enable forced RTL layout at your devices developer settings, while still having english language set.

@karmac2015
Copy link
Contributor Author

Hello, @jtj9817 I have finished modifying the project Simple-Contacts to support RTL, take a look at the changes I have made here

@jtj9817
Copy link
Contributor

jtj9817 commented Jan 21, 2019

Hey @karmac2015 , thanks for the reference code. I'm sure I will find it helpful and I'll take a look at it.

jtj9817 added a commit to jtj9817/Simple-Calendar that referenced this issue Jan 25, 2019
@jtj9817
Phase One for issue SimpleMobileTools#751
a577f4d 
Refactored code for XML layout files involved for adding RTL support
@jtj9817 jtj9817 mentioned this issue Jan 25, 2019
Merged
tibbi added a commit that referenced this issue Jan 26, 2019
@tibbi
Merge pull request #762 from jtj9817/master
1d0d0a8 
Phase One for RTL Support #751
@jtj9817 jtj9817 mentioned this issue Jan 27, 2019
Open
@schapira
Copy link
Contributor

can I help in that? what can I do?

@tibbi
Copy link
Member

tibbi commented May 20, 2019

only developers can help, with adjusting the appropriate code and layouts

@schapira
Copy link
Contributor

schapira commented May 20, 2019 via email •
edited

@tibbi
Copy link
Member

tibbi commented May 20, 2019

well so test the app and see what xml changes need to be done, so that it works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@schapira @tibbi @karmac2015 @jtj9817