Phase One for RTL Support #751 #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored code for XML layout files involved for adding RTL support
Deleted v17 landscape layout version of fragment_year.xml
tibbi
reviewed
Jan 25, 2019
app/release/output.json
Outdated
| @@ -0,0 +1 @@ | |||
| [{"outputType":{"type":"APK"},"apkInfo":{"type":"MAIN","splits":[],"versionCode":141,"versionName":"6.2.1","enabled":true,"outputFile":"calendar-release.apk","fullName":"release","baseName":"release"},"path":"calendar-release.apk","properties":{}}] | |||
There was a problem hiding this comment.
remove these 3 files from the pull request
There was a problem hiding this comment.
Just finished deleting them. Any ideas on why the /release folder was present?
There was a problem hiding this comment.
not sure how come it doesnt show to me either actually, since it isnt added to .gitignore. Anyway before doing a commit always check what files are modified. Looks good now, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this PR for issue #751 and if there are any changes that need to be made please comment on them.