Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase One for RTL Support #751 #762

Merged
merged 7 commits into from Jan 26, 2019

Conversation

Projects
None yet
2 participants
@jtj9817
Copy link
Contributor

commented Jan 25, 2019

Please review this PR for issue #751 and if there are any changes that need to be made please comment on them.

jtj9817 added some commits Jan 25, 2019

Phase One for issue #751
Refactored code for XML layout files involved for adding RTL support
Phase One Addendum
Deleted v17 landscape layout version of fragment_year.xml
@@ -0,0 +1 @@
[{"outputType":{"type":"APK"},"apkInfo":{"type":"MAIN","splits":[],"versionCode":141,"versionName":"6.2.1","enabled":true,"outputFile":"calendar-release.apk","fullName":"release","baseName":"release"},"path":"calendar-release.apk","properties":{}}]

This comment has been minimized.

Copy link
@tibbi

tibbi Jan 25, 2019

Member

remove these 3 files from the pull request

This comment has been minimized.

Copy link
@jtj9817

jtj9817 Jan 26, 2019

Author Contributor

Just finished deleting them. Any ideas on why the /release folder was present?

This comment has been minimized.

Copy link
@tibbi

tibbi Jan 26, 2019

Member

not sure how come it doesnt show to me either actually, since it isnt added to .gitignore. Anyway before doing a commit always check what files are modified. Looks good now, thanks.

jtj9817 added some commits Jan 26, 2019

@tibbi tibbi merged commit 1d0d0a8 into SimpleMobileTools:master Jan 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.