Score submission is enabled when autoplay has been disabled before the end of the song

[florczakraf]

Summary

Automatic score submission doesn't consider the fact that autoplay was present during the song, it's only checked at the end, which in turn can cause scores like the one below to be submitted:

Reproduction steps

• start a song
• enable autoplay
• let it play for a while
• disable autoplay somewhere before the end of the song
• start playing so that you have score > 0 and your lifebar is > 0 (GS seem to reject 0% scores but the submission also happens in that case)
• wait for the result screen

Expected behavior

Disable the QR and automatic score submission with a proper reason like below (screenshot taken when played with autoplay until the end):

Possible solutions

I'm not really familiar with the code of SL or the engine itself but it seems that the current approach of verifying the autoplay relies on the engine:

IsAutoplay = function(player)
	return GAMESTATE:GetPlayerState(player):GetPlayerController() == "PlayerController_Autoplay"
end

which doesn't track the fact that the autoplay was present during a song. Therefore it might be a lot of work to fix it that way. However, I noticed that the scores submitted after playing with autoplay have inconsistent number of steps (they do not sum up to total steps):

so we could probably use that to verify the integrity of the score.