Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the POC ConfigsManager as the new ConfigsManager Step 1 #147

Closed
3 tasks
dillu24 opened this issue Apr 6, 2022 · 2 comments
Closed
3 tasks

Make the POC ConfigsManager as the new ConfigsManager Step 1 #147

dillu24 opened this issue Apr 6, 2022 · 2 comments

Comments

@dillu24
Copy link
Collaborator

dillu24 commented Apr 6, 2022

Technical Story

The alerter needs to be notified whenever there is a configuration change.

Description

Since we are now storing the configurations inside the database we must be able to detect a configuration change by listening to database events. This means that we need to migrate the POC logic that @simplyrider has developed and replace the old ConfigsManager

Requirements

  • The new configs manager is able to map the structure of the new configurations into the old structure. This is needed so that the alerter can continue operating without any changes.
  • The new configs manager is able to detect a change inside a configuration and send the entire configuration to the CONFIG_EXCHANGE with the correct routing key
  • Connect the new ConfigsManager with run_alerter.py in order for the manager to start

Extra attention should be put towards the following:

  • On startup we need to send all configurations from the database.
  • Error handling should be implemented similarly to the old ConfigsManager
  • Proper thread handling of the newly created threads.
  • Dynamic RabbitMQ routing keys based on configs.

Acceptance criteria

Given: Any Substrate configuration change
Then: The ConfigsManager sends the correct configuration update with the correct routing key

Given: Any Cosmos configuration change
Then: The ConfigsManager sends the correct configuration update with the correct routing key

Given: Any Chainlink configuration change
Then: The ConfigsManager sends the correct configuration update with the correct routing key

Given: Any General configuration change
Then: The ConfigsManager sends the correct configuration update with the correct routing key

@dillu24 dillu24 added this to the UI iteration 2 milestone Apr 6, 2022
@dillu24 dillu24 changed the title Migrate POC logic to Configs Manager Make the POC ConfigsManager as the new ConfigsManager Jun 9, 2022
@dillu24 dillu24 removed the 13 SP label Jun 9, 2022
@rider-cantuaria-eng rider-cantuaria-eng changed the title Make the POC ConfigsManager as the new ConfigsManager Make the POC ConfigsManager as the new ConfigsManager Step 1 Aug 3, 2022
@dillu24
Copy link
Collaborator Author

dillu24 commented Aug 12, 2022

Part of this ticket is to create a presentation to the team so that everyone is aware of what needs to be done.

@itsciccio
Copy link
Collaborator

Not merged. Will first have #334 merged into it since as-is, heartbeats do not work. Once this is merge is complete, we are to merge this branch into ui_iteration_2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants