Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A typo on interface name! #3

Closed
Ali-RS opened this issue Jul 22, 2021 · 3 comments
Closed

A typo on interface name! #3

Ali-RS opened this issue Jul 22, 2021 · 3 comments

Comments

@Ali-RS
Copy link

Ali-RS commented Jul 22, 2021 •
edited
Loading

Hi

Looks like a typo here. I guess it should be "Filtered", not "Filterd". Of course, will be a breaking change to fix.

SimMath/src/main/java/com/simsilica/mathd/filter/Filterd.java

Line 47 in b428c25

public interface Filterd {

@pspeed42
Copy link
Contributor

Vec3d, Quatd, Filterd. No typo.

If I was ever crazy enough to make a float version then it would be called Filterf.

@Ali-RS
Copy link
Author

Ali-RS commented Jul 22, 2021 •
edited
Loading

Ah, I see. Sorry for the misunderstanding.

@Ali-RS Ali-RS closed this as completed Jul 22, 2021
@pspeed42
Copy link
Contributor

pspeed42 commented Jul 23, 2021 •
edited
Loading

No worries. Thanks for keeping me own my toes. Even I had a 5 second panic that I'd checked in a typo in a file name. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ali-RS @pspeed42