Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VQ-Layer Replacement Feature #70

Closed
FlorianPfisterer opened this issue Oct 3, 2018 · 0 comments
Closed

VQ-Layer Replacement Feature #70

FlorianPfisterer opened this issue Oct 3, 2018 · 0 comments
Assignees
@Simsso @FlorianPfisterer
Labels
code Software is relevant or involved work-item Tasks
Milestone
14. Working Group...

Comments

@FlorianPfisterer
Copy link
Collaborator

FlorianPfisterer commented Oct 3, 2018 •
edited
Loading

Problem: the current implementation does not work with the virtual batch size feature (#64).
We need to evaluate how exactly we want to handle this. Also, we need to disable the replacement when is_training is false, as this might crash for small batch sizes (and it's also plain wrong).
@FlorianPfisterer FlorianPfisterer added code Software is relevant or involved work-item Tasks labels Oct 3, 2018
@Simsso Simsso mentioned this issue Oct 3, 2018
Closed
11 tasks
@Simsso Simsso added this to the 14. Working Group Meeting milestone Oct 3, 2018
This was referenced Oct 3, 2018
Closed
Merged
@Simsso Simsso closed this as completed Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simsso Simsso

@FlorianPfisterer FlorianPfisterer

Labels
code Software is relevant or involved work-item Tasks
Projects
None yet
Milestone
14. Working Group Meeting
Development

No branches or pull requests
2 participants
@Simsso @FlorianPfisterer