Admin nav #1
Closed
Admin nav #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sinetheta
force-pushed
the
admin-nav
branch
25 times, most recently
from
67636bd
to
52397ae
Compare
Sinetheta
force-pushed
the
admin-nav
branch
3 times, most recently
from
db72878
to
03872e3
Compare
A revision of 11744f3, where we began hiding api keys. This replaces them with (hidden) so that they are hidden, preventing privilege escalation, but it is clear if the user has an api key.
Sinetheta
force-pushed
the
admin-nav
branch
3 times, most recently
from
764a43b
to
9a4090c
Compare
Fixed no implicit conversion of Hash into String error
Leaving image files open is a bad idea when seeding image data
Use git ls-files for the gemspec file listing
Fix typo field_container meta_keywords
We want the submenu available for all pages, not just product pages.
We want the submenu available for all pages, not just promotion pages.
We want the submenu available for all pages, not just stock pages.
If we want a nested nav structure then we need a way of passing subnav content to the tab helper which generates nav elements.
We use powertip to provide tooltips. It doesn't however work very well under test. It turns out that the tips were appearing somewhere off-page beneath the content. Which meant that they were out of the way and tests passed. Nobody asked why. It just was. Moving the flash notifications has somehow changed that. Now powertips block *some* interactive elements *sometimes*. Red tests, bad times. But adding this padding fixes the issue. Since it wasn't possible to click on powerTips anyways, removing pointer-events from them has no effect when they're working. It does however prevent them from getting in the way of clicks when they are *not* working (eg: in test).
The logo is aligned with the now highest level page item, the .page-title The current user links which are defaced in by solidus_auth_devise are now placed in a sticky footer for the sidebar.
This is the little triangle guy which makes popups and dropdowns "belong" to something. This is the simplest form of those dongles, an :after pseudo element. In order to add a border to the caret we could overlay it on a :before element and use some css magic to offset them slightly. This would be a great thing to demo on a style guide/
The notable features here are - Vertical list of main nav items with icons - Active subnav is shown as an expanded accordion - Other subnavs are exposed as flyouts on hover
To distinguish the left sidebar (main navigation) from the right sidebar (3rd level of navigation which appears in the content area) we will refer to it as the .admin-nav This also fixes a css spillover from using the class .sidebar which was causing the right sidebar to be misplaced. We will, however, avoid renaming templates when at all possible to prevent breaking users Deface overrides.
Instead of using deface we prefer an empty template to override.
To prevent them from laying on top of the, now higher, main content.
Safer than specific vertical offsets is a vertically centered image.
Although this menu is inserted by the gem solidus_auth_devise, the styles have much more to do with now this particular area is styled. Since we're also talking about a very small amount of css, in a nearly ubiquitous gem, I feel comfortable including these styles in solidus itself.
This prevents the login nav from appearing to "float" beneath the admin nav when there's plenty of room for both on the screen.
spree@example.com is great, but we don't want MikeAtYahooDotCom@hotmail.com spilling out of the sidebar
|
merge solidusio#509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.