Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgrid 1.2.0 breaks OnDemandGrid with more than 25 items in store #1382

Closed
baraclese opened this issue Jun 22, 2017 · 3 comments
Closed

dgrid 1.2.0 breaks OnDemandGrid with more than 25 items in store #1382

baraclese opened this issue Jun 22, 2017 · 3 comments
Assignees

Comments

@baraclese
Copy link

baraclese commented Jun 22, 2017

I tested this in Firefox 54 and Chrome 59.
I upgraded from 1.1.0 to 1.2.0 and all my OnDemandGrids break if they contain more than 25 items. For example I have a grid with a button to add new rows, as I add them to the collection they are rendered fine, but then I change the sort order on a column and only 25 rows will be rendered (although the grid is larger than 25 rows). I logged the fetchRangeSync calls to dstore/Memory and see that it only requests the first 25 items. I switch back to dgrid-1.1.0 and see two fetchRangeSync calls for the first 25 and then for the rest.

Reverting commit 8b55948 fixes the issue.

@TiBeN
Copy link

TiBeN commented Jun 22, 2017

I was on the way to post the same issue! Tests availables at this page http://dgrid.io/js/dgrid/test/OnDemand_promises.html are broken with firefox 54 and google chrome 59.0.3071.109-1. There is any loading triggers to occur after the initial 25 rows set.

@edhager
Copy link
Member

edhager commented Jun 26, 2017

A change was landed that fixes an issue with calculating the average row height.

@edhager edhager closed this as completed Jun 26, 2017
@TiBeN
Copy link

TiBeN commented Jun 30, 2017

Thanks for your work on this issue. I've tested today and confirm it has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants