-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observable cannot properly report the position of objects added using the before option #6
Comments
Just FYI, we do plan to address this issue in the next month. |
Thanks @kriszyp |
Kris, very humbling advice from a very humble developer...
Zero optimisation, it's meant to show exactly what I am doing. The main difference is that it does NOT assume that the data is stored locally. This means that we need to tell it where the data is meant to be placed To make this happen, there are some necessary API changes. Just my 2c. I tried to simplify things as much as possible, I hope it helps... |
The is one more use-case that I address in https://github.com/mercmobily/hotplate/blob/master/node_modules/hotDojoStores/client/JsonObservable.js and I think it's worthwhile covering it in this ticket while it's being worked on: That is: a list of comments, with a comment form at the top. The list of comments is an OnDemandList, displaying query sorted by Date. When a new comment gets added, I would like to add it to the top of the list (most recent comments are added to the top) That's why in JsonObservable I have a It's very possible that there is a better solution to this use case -- something that allows Observable to place an item at the beginning or the end without doing a full refresh. (Note: using |
I just realised that the link to my previous comment is incorrect -- sorry about that. |
Hi, These (proposed) changes are now in the options-before branch: One Notes dgrid needs to be changed accordingly so that it passes I will go through the code, and test it on a real world application, tomorrow. Thank you for doing it. |
I shouldn't write comments late at night. dstore already passes |
Have you had a chance to test this? Can we close this? |
This is now fully fixed. |
It seems to me that the TRAC issue https://bugs.dojotoolkit.org/ticket/17642 opened for dojo/Store still applies to dstore Observable.
The text was updated successfully, but these errors were encountered: