Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use ES3 target option - propose using strings for setting the target option instead. #34

Closed
sccolbert opened this issue Aug 15, 2015 · 0 comments
Assignees
Labels
Milestone

Comments

@sccolbert
Copy link

This line will fail if the target option is set to ts.ScriptTarget.ES3, because that value is 0 and will test false:
https://github.com/SitePen/dts-generator/blob/master/index.ts#L104

Futhermore, it's not completely safe for a user to require typescript and pass along that enum value, since it may come from a version of typescript which is different than the one imported by dts-generator. The safest/simplest way to fix both issues is to use a string for the target option.

@kitsonk kitsonk added the bug label Aug 20, 2015
@kitsonk kitsonk added this to the 1.6.0 milestone Sep 4, 2015
@kitsonk kitsonk self-assigned this Sep 4, 2015
@kitsonk kitsonk modified the milestones: 1.7.0, 1.6.0 Nov 3, 2015
@kitsonk kitsonk modified the milestones: 1.6.1, 1.7.0 Nov 3, 2015
@kitsonk kitsonk modified the milestones: 1.7.0, 1.6.3 Mar 1, 2016
@kitsonk kitsonk closed this as completed in e45fb74 Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants