Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self reference in type parameter defaults in alfa-css\src\values.ts #102

Closed
singingknight opened this issue Feb 18, 2019 · 1 comment

Comments

@singingknight
Copy link
Contributor

Typescript 3.3 introduces a breaking change:No self or forward references in type parameter defaults

This makes the definition of Value in packages\alfa-css\src\values.ts invalid.

@kasperisager
Copy link
Contributor

Good catch! It's effectively used as any in that particular case, though that is an issue in and of itself.

kasperisager added a commit that referenced this issue Feb 22, 2019
* master: (22 commits)
  Welcome @singingknight as a collaborator
  Fix a typo
  Better windows support (#104)
  Moving format check from diagnose to prepare (#99)
  Ensure that .git folder is also ignored
  Build browser list
  Add type assertion for enzyme wrappers
  Upgrade packages and run Prettier
  Declare missing files
  Progress on `fulfills()` spec
  Add `subtract()` and `union()`
  Some alfa compatibility tests (#89)
  Implement `isExposed()` and refactor `isVisible()`
  Refactor `Option` type and associated functions
  Initial documentation of ACT types
  Update TypeScript
  Fixes #102: Make `Value` type default to `unknown`
  Better tracking of `Project` version
  Cache working directory and internalise properties
  Minor refactoring of `Project`
  ...
kasperisager added a commit that referenced this issue Feb 23, 2019
* master:
  Welcome @singingknight as a collaborator
  Fix a typo
  Better windows support (#104)
  Moving format check from diagnose to prepare (#99)
  Ensure that .git folder is also ignored
  Build browser list
  Add type assertion for enzyme wrappers
  Upgrade packages and run Prettier
  Declare missing files
  Progress on `fulfills()` spec
  Add `subtract()` and `union()`
  Some alfa compatibility tests (#89)
  Implement `isExposed()` and refactor `isVisible()`
  Refactor `Option` type and associated functions
  Initial documentation of ACT types
  Update TypeScript
  Fixes #102: Make `Value` type default to `unknown`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants