Better windows support #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A known bug (character.js timeout) caused the build to fail. I have restarted the build. Edit: It might actually be a coincidence that it stops at character.js. Seemingly it is terminated when format task fails. Wait for #99 to get merged, then we can see if the build works. |
kasperisager
suggested changes
Feb 21, 2019
scripts/prepublish.js
Outdated
| @@ -62,7 +65,7 @@ function references(directory, pkg, options = {}, additional = []) { | |||
| and(endsWith(".ts", ".tsx"), not(endsWith(".d.ts"))) | |||
| ) | |||
| ] | |||
| .map(file => path.relative(directory, file)) | |||
| .map(file => path.relative(directory, file).replace(/\\/g, "/")) | |||
There was a problem hiding this comment.
path.relative(directory, file).split(path.sep).join("/")
added 2 commits
February 21, 2019 13:26
…ve/alfa into better-windows-support
kasperisager
added a commit
that referenced
this pull request
Feb 22, 2019
* master: (22 commits) Welcome @singingknight as a collaborator Fix a typo Better windows support (#104) Moving format check from diagnose to prepare (#99) Ensure that .git folder is also ignored Build browser list Add type assertion for enzyme wrappers Upgrade packages and run Prettier Declare missing files Progress on `fulfills()` spec Add `subtract()` and `union()` Some alfa compatibility tests (#89) Implement `isExposed()` and refactor `isVisible()` Refactor `Option` type and associated functions Initial documentation of ACT types Update TypeScript Fixes #102: Make `Value` type default to `unknown` Better tracking of `Project` version Cache working directory and internalise properties Minor refactoring of `Project` ...
kasperisager
added a commit
that referenced
this pull request
Feb 23, 2019
* master: Welcome @singingknight as a collaborator Fix a typo Better windows support (#104) Moving format check from diagnose to prepare (#99) Ensure that .git folder is also ignored Build browser list Add type assertion for enzyme wrappers Upgrade packages and run Prettier Declare missing files Progress on `fulfills()` spec Add `subtract()` and `union()` Some alfa compatibility tests (#89) Implement `isExposed()` and refactor `isVisible()` Refactor `Option` type and associated functions Initial documentation of ACT types Update TypeScript Fixes #102: Make `Value` type default to `unknown`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit when tsconfig.json is updated
Previously it was updated with windows relative path in files.
Previously the manifests wasn't formatted on update.