Some alfa compatibility tests #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperisager
approved these changes
Feb 20, 2019
kasperisager
added a commit
that referenced
this pull request
Feb 22, 2019
* master: (22 commits) Welcome @singingknight as a collaborator Fix a typo Better windows support (#104) Moving format check from diagnose to prepare (#99) Ensure that .git folder is also ignored Build browser list Add type assertion for enzyme wrappers Upgrade packages and run Prettier Declare missing files Progress on `fulfills()` spec Add `subtract()` and `union()` Some alfa compatibility tests (#89) Implement `isExposed()` and refactor `isVisible()` Refactor `Option` type and associated functions Initial documentation of ACT types Update TypeScript Fixes #102: Make `Value` type default to `unknown` Better tracking of `Project` version Cache working directory and internalise properties Minor refactoring of `Project` ...
kasperisager
added a commit
that referenced
this pull request
Feb 23, 2019
* master: Welcome @singingknight as a collaborator Fix a typo Better windows support (#104) Moving format check from diagnose to prepare (#99) Ensure that .git folder is also ignored Build browser list Add type assertion for enzyme wrappers Upgrade packages and run Prettier Declare missing files Progress on `fulfills()` spec Add `subtract()` and `union()` Some alfa compatibility tests (#89) Implement `isExposed()` and refactor `isVisible()` Refactor `Option` type and associated functions Initial documentation of ACT types Update TypeScript Fixes #102: Make `Value` type default to `unknown`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a batch of some of the missing spec files in alfa-compatibility. I find the package somewhat confusing to read. I suggest some refactoring or documentation so that the package is more readable and understandable.