Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use overloads while passing culture #359

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Sep 25, 2023

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Roslyn is incorrectly flagging CA1304 against the codebase following the move to .NET 6. I can't stop it doing that but I did find areas where we were not using the overloads correctly in our FontCollection based types.
354

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #359 (429d527) into main (a70c2be) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            main    #359   +/-   ##
=====================================
  Coverage     86%     86%           
=====================================
  Files        238     238           
  Lines      15171   15171           
  Branches    2100    2100           
=====================================
  Hits       13073   13073           
  Misses      1613    1613           
  Partials     485     485           
Flag Coverage Δ
unittests 86% <100%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/SixLabors.Fonts/FontCollection.cs 88% <100%> (ø)
src/SixLabors.Fonts/SystemFontCollection.cs 52% <100%> (ø)
src/SixLabors.Fonts/SystemFonts.cs 100% <100%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JimBobSquarePants JimBobSquarePants merged commit e646d68 into main Sep 25, 2023
9 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/fix-culture-warnings branch September 25, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants