Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"place" option gone? #89

Closed
graulund opened this issue Jan 18, 2015 · 1 comment
Closed

"place" option gone? #89

graulund opened this issue Jan 18, 2015 · 1 comment

Comments

@graulund
Copy link

Hi! Thanks for this script!

I downloaded it, and found that no matter how hard I tried, the option place: 'end' does not seem to work. The unsorted elements remain in their place.

Then I look in the source code and see that place is not mentioned anywhere in the tinysort.js code, other than in the documentation comments — and indeed, tinysort.js:47 says //todo check place option.

Is the place feature still alive?
Thanks again!

@Sjeiti
Copy link
Owner

Sjeiti commented Jan 18, 2015

You're right, I totally missed that. That's what you get for refactoring solely on unit-tests ('place' had no tests). I'll check and hopefully reimplement the functionality in the upcoming week.

@Sjeiti Sjeiti closed this as completed in bfc7204 Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants