Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user if there is nothing to export #156

Closed
thomthom opened this issue May 1, 2015 · 7 comments
Closed

Warn user if there is nothing to export #156

thomthom opened this issue May 1, 2015 · 7 comments

Comments

@thomthom
Copy link
Member

thomthom commented May 1, 2015

Instead of exporting an empty STL file if the model is empty or the Export Selected is checked and selection is empty it would be better to alert the user.

@thomthom thomthom added this to the Version 2.2 milestone May 1, 2015
@jimfoltz
Copy link
Contributor

What do you think - a single message, or separate messages tailored to either situation of "model empty" or "selection empty"? I just want to make the wording as clear as possible for everyone.

"There is nothing to export. Either the model or the selection is empty."
OR
"There is nothing to export. The model is empty."
"There is nothing to export. The selection is empty."

@jimfoltz
Copy link
Contributor

wtf. Sigh.

@thomthom
Copy link
Member Author

I think I lean toward the latter - specific for each scenario - as it aids the user better in what is expected based on the selected preferences. Though, any message is better than none.

@jimfoltz
Copy link
Contributor

jimfoltz commented Jan 5, 2017

Before I start on this, here's an outline of the plan:

  • Remove the validation proc that disables the "Export STL" menu item when the model is empty. Since new warnings will be added to prevent export of an empty .stl file, there is less reason to disable the menu. Also, I just don't like the disabled menu - there is no explaination why is is unavailable and no way to get an explaination.

  • When the user selects "Export STL" and the model is empty, display a warning, then exit.

  • At the time the export dialog opens, automatically check or uncheck the "Export selected" option. Make the assumption if the user begins an export with something selected, the intention is to export only the selection.

@thomthom
Copy link
Member Author

thomthom commented Jan 6, 2017

Sounds good to me.

The disabled menu issue is something I've read about a few times in terms of UX issues with the common convention of disabling. You echo what those article said, the user is unable to learn why the menu is disable.

One question about the selection, what if the selection is just edges or faces? Do we export just those? Or does it make sense to detect selected group/component instances and use that to determine the "Export selected" option?

@jimfoltz
Copy link
Contributor

jimfoltz commented Jan 7, 2017

I looked at all the Pro exporters. Only the FBX and 3DS exporters had the option to export only the selection. Both of them went ahead and exported without a message if nothing was selected. I am not saying we should do the same, though.

SketchUp also diasbles the Export > 3D Model menu when the model is empty. So if the Exporter API Interface is ever added and the STL exporter uses it then it will be disabeld also by default.

@thomthom
Copy link
Member Author

thomthom commented Jan 7, 2017

Ah, yes, the Exporter interface. I've been wanting to get that added for a long time. I'll see if I can bump that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants