Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directional block comparison is broken on 1.12 #2711

Closed
antoinech2 opened this issue Dec 20, 2019 · 5 comments
Closed

Directional block comparison is broken on 1.12 #2711

antoinech2 opened this issue Dec 20, 2019 · 5 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. legacy versions Issues or PRs which are only applicable for the server versions 1.9-1.12 priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@antoinech2
Copy link

antoinech2 commented Dec 20, 2019

Description

A lot of item name do not seem to work and comparison is very hard to do.

Steps to Reproduce

Player head in hand:
send "%tool of player%"
Output: "south facing ender dragon head"

dirch door in hand:
send "%tool of player%"
Output: "right-hinged closed top birch wood door"

Moreover, comparaison are destroyed. You have to compare with the EXACT item name
Ex: if tool of player is head or player head doesn't work
Also, it's impossible to compare a type of door, or all types of door
if targeted block of player is door, any door, any wood door, birch door, closed birch door None of them works!

Server Information

  • Server version/platform: PaperSpigot 1.12
  • Skript version: 2.4 (last version)

Additional Context

It very complicated to compare items, and it destroys a lot of my skripts. Please help ;)

@ShaneBeee
Copy link
Contributor

  1. I recommend if you are going to post an issue and you require help, don't insult the team by saying their work is "ridiculous or stupid"... that is just blatantly rude. TheBentoBox (mostly) and other people spent a LOT of time writing the aliases, trying their best to make sure they were suitable for all users and properly expressed their types. Insulting them by saying they're stupid is just unneeded on this issue tracker, and get's you no where.
    (I have edited your message to remove the rude comments)

Ex: if tool of player is head or player head doesn't work

I tried this exact line of code, and it works with no issues. I gave myself a head of myself, and that condition returns true.

  1. As for the door comparison issue. We will look into this. I will mark it as a bug.

@ShaneBeee ShaneBeee added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Dec 20, 2019
@antoinech2
Copy link
Author

antoinech2 commented Dec 20, 2019

I may have expressed myself badly but I was not talking about the work of the developers (which I respect a lot), but the name of the items which seems very strange and bizarre to me. Sorry for the misunderstanding.

I'll make some more tests to verify the comparaison of the player head.

@bensku
Copy link
Member

bensku commented Dec 20, 2019

FYI, the comparison issues are mostly specific to 1.12 and older Minecraft versions. While Minecraft 1.12 does use block states, Spigot API got good support for them only in 1.13.

@antoinech2 If you can update to Minecraft 1.14 or 1.15, I would recommend that. Comparison issues might not ever be fully solved on 1.12.

@legofreak1999
Copy link

Issue Regarding Head

@APickledWalrus
Copy link
Member

This might work better now with #3419
I'll do some testing.

@TPGamesNL TPGamesNL added the legacy versions Issues or PRs which are only applicable for the server versions 1.9-1.12 label Jun 22, 2021
@TheLimeGlass TheLimeGlass changed the title Some aliases not working Directional block comparison is broken on 1.12 Oct 20, 2022
@TheLimeGlass TheLimeGlass added the PR available Issues which have a yet-to-be merged PR resolving it label Mar 10, 2023
@TheLimeGlass TheLimeGlass added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. legacy versions Issues or PRs which are only applicable for the server versions 1.9-1.12 priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

No branches or pull requests

7 participants