Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[the] bed[s] [location[s]] of %offlineplayers% #4659

Closed
1 task done
kossnikita opened this issue Mar 11, 2022 · 2 comments
Closed
1 task done

[the] bed[s] [location[s]] of %offlineplayers% #4659

kossnikita opened this issue Mar 11, 2022 · 2 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@kossnikita
Copy link

Suggestion

The method currently used to find the bed is Player.getBedSpawnLocation()
This does not allow you to find the beds of players who are not currently online.
Bukkit has a method OfflinePlayer.getBedSpawnLocation()
This method can replace the current one and it will work for both online and offline players.

Why?

I ran into a problem when I wanted to find out all the players who own a certain bed. And I found that I can't do that with %offlineplayers%'[s] bed[s] [location[s]]. This expression only works with online players.

Other

In my opinion, this change cannot affect already existing scripts.

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@TPGamesNL TPGamesNL added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Mar 11, 2022
@AyhamAl-Ali AyhamAl-Ali mentioned this issue Mar 11, 2022
Merged
@AyhamAl-Ali AyhamAl-Ali added the PR available Issues which have a yet-to-be merged PR resolving it label Mar 11, 2022
@TheLimeGlass TheLimeGlass added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Jul 20, 2022
@AyhamAl-Ali AyhamAl-Ali reopened this Sep 19, 2022
@AyhamAl-Ali
Copy link
Member

@kossnikita We do not close completed issues until a new release including them is out :)

@kossnikita
Copy link
Author

Oh, I'm sorry! It seemed to me that this was already included in the release after the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@TheLimeGlass @AyhamAl-Ali @Pikachu920 @TPGamesNL @kossnikita